Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mc idp ldap accesskey create --login to mc idp ldap accesskey create-with-login #4894

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

taran-p
Copy link
Contributor

@taran-p taran-p commented Apr 4, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Moves mc idp ldap accesskey create --login into a new command, mc idp ldap accesskey create-with-login
Fixes help for accesskey create

Motivation and Context

create --login has a fundamentally different input than create without the flag, so it makes sense to split them

How to test this PR?

Enable LDAP on server and use mc idp ldap accesskey create-with-login command

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@taran-p taran-p requested a review from donatello April 4, 2024 23:47
@harshavardhana harshavardhana merged commit e701bce into minio:master Apr 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants