mirror: let user decide whether to skip errors if client runs in watch / active-active mode #4986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #4883
Motivation and Context
When client has run with
--watch
and minio servers are down (or encounter a network error),watch
request and mirroring progress will not recover forever after serveral retries.In version 2022-04-01, mirroring progress will be cancelled and restarted when
statusCh
returns ano-ignored
error.After PR 4032, mirroring progress will not be restarted forever when client runs with
--watch
and/or--active-active
.This patch restores the "restart" policy in version
2022-04-01
and users can also pass--skip-errors
to keep same behavior of current implementation.How to test this PR?
mc mirror --watch --remove --overwrite --debug --summary [alias]/[bucket]/path/ ./
Types of changes
Checklist:
commit-id
orPR #
here)