Fix case-sensitive comparison for ETag
#268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poornas
approved these changes
Jan 4, 2019
|
All HTTP headers interpreted should be case insensitive @poornas - we may need to check if we have more places such as these. |
|
will do @harshavardhana |
|
@harshavardhana Will merge this PR now. @poornas will be sending in another PR to fix the remaining ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having issues where sometimes the
ETagheader parameter would come asEtag, which would causeObjectStat.ETagto be an empty string.Making the string comparison case-insensitive fixed the issue.