Add request date to PresignedGetObjectAsync as an optional parameter #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@poornas, this PR doesn't fix #289. As discussed in the issue, there are two possible fixes,
So, we could close the issue with option 2. This PR is an improvement to minio-dotnet nevertheless and can be taken in. But merging this PR shouldn't automatically close the issue. I'd recommend removing |
krisis
reviewed
Mar 7, 2019
|
@poornas please rebase it. |
poornas
force-pushed
the
presignget
branch
2 times, most recently
from
25c73bf
to
069714c
Compare
sinhaashish
approved these changes
Mar 7, 2019
krisis
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.