Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* Improve testability with IMinioClient interface #688

Merged
merged 5 commits into from
Dec 12, 2022
Merged

* Improve testability with IMinioClient interface #688

merged 5 commits into from
Dec 12, 2022

Conversation

luizcarlosfaria
Copy link
Contributor

  • Improving testability with IMinioClient interface
  • Adding all non deprecated operations to IMinioClient
  • Removing factory (With*()) operations from interface keeping on MinioClient class.

@ebozduman
Copy link
Collaborator

@luizcarlosfaria

Please run dotnet regitlint on your branch as there are lint issues in some of the modified files.
After that, obviously you need to push your changes again.

luizcarlosfaria and others added 3 commits October 31, 2022 23:21
@luizcarlosfaria @ebozduman
* Improve testability with IMinioClient interface
611710d 
* Adding all non deprecated operations to IMinioClient
* Removing factory (With*()) operations from interface mantaining on MinioClient class.
@ebozduman
Fixes the lint errors
bb494e0
@ebozduman
Merge branch 'master' into master
8f2ec71
ebozduman
ebozduman reviewed Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please rebase your branch.

  • There are some more references to MinioClient minio which might also be replaced with the new interface:
    1 in README
    1 in Minio/Credentials/IAMAWSProvider.cs
    3 in Minio.Examples/Cases/ListenBucketNotifications.cs, ../ListIncompleteUploads.cs, ../ListObjects.cs
    and some more in Minio.Frunctional.Tests/FunctionalTest.cs

@harshavardhana
Copy link
Member

@ebozduman let's take this PR and you can make those relevant changes?

@ebozduman
Copy link
Collaborator

Will do.

@harshavardhana harshavardhana merged commit 50f15fb into minio:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@poornas poornas Awaiting requested review from poornas

@ebozduman ebozduman Awaiting requested review from ebozduman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luizcarlosfaria @ebozduman @harshavardhana