Upgrading from v7.0.29 to v7.0.32 introduced a go routine leak

[emilhjd]

Did the upgrade, noticed the leak, reverted back to v7.0.29 and the go routine leak was gone.

Will try and identify the leak more precisely, but maybe it is quite clear to someone what happened given that is was recently introduced.

[harshavardhana]

This is not enough, you have to tell us exactly what you did and profile your application share the profiles here.

[harshavardhana]

Closing @emilhjd please let us know once you have the profiles.

[alexanderpalsson]

@harshavardhana we are having a lot of trouble with go routines getting stuck in the for loop. Seems like the reqChannel never closes after this change 42c18ba#diff-282c3c5bf47067eafde30e0ed6f8df086049b4b48891586a3e611b01036f600bL78-L85. Since the channel closing with a defer it's never closed since there is nothing triggering the return after the ctx.Done was removed.

Maybe we are doing something wrong here, but just using the close method doesn't seem to close the channel.

[harshavardhana]

@alexanderpalsson will check

[harshavardhana]

@alexanderpalsson can you take a look at the PR #1687 and test it?

[alexanderpalsson]

@harshavardhana looks good thank you 😃