Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region caching needs to take care cache invalidation #273

Closed
balamurugana opened this issue Dec 22, 2015 · 2 comments
Closed

region caching needs to take care cache invalidation #273

balamurugana opened this issue Dec 22, 2015 · 2 comments
Assignees

Comments

@balamurugana
Copy link
Member

As the library caches bucket region, we would need to take care below cases

  • if a bucket is deleted after the bucket gets cached, we would need to invalidate the cache if we get the request for the same bucket
  • if a bucket is deleted and recreated after the bucket gets cached, we would need to invalidate the cache if we get region mismatch errors from amazon s3
@harshavardhana
Copy link
Member

retry logic in this is needed for two cases and

  • 400 Bad Request

<Error><Code>400 Bad Request</Code><Message>400 Bad Request</Message><BucketName>anythinglikenothing</BucketName><Key></Key><RequestId>10B1CB41110FF511</RequestId><HostId>6CfZYjQ1pUjINOsAszS29xrc/7y73Mb26GNCdizVauaUeZ4sAMQwusx/lTn2KI8p19HnM27ZqrM=</HostId><AmzBucketRegion>us-west-2</AmzBucketRegion></Error>

  • AuthorizationHeaderMalformed

<Error><Code>AuthorizationHeaderMalformed</Code><Message>The authorization header is malformed; the region &#39;us-east-1&#39; is wrong; expecting &#39;us-west-2&#39;</Message><BucketName></BucketName><Key></Key><RequestId>1531B8C99ED42ACD</RequestId><HostId>47gvFpzOkdf9Kyr/G0mAvqCu55osRPtNjtYuIUPmm+yxXrjd+aIneNqukwhM1K0IOu3pG61+zCY=</HostId><AmzBucketRegion></AmzBucketRegion></Error>

@harshavardhana
Copy link
Member

Keeping them here to remember.

harshavardhana pushed a commit to harshavardhana/minio-go that referenced this issue Dec 25, 2015
Additionally saves the location from MakeBucket request.

Fixes minio#273
harshavardhana pushed a commit that referenced this issue Dec 26, 2015
Additionally saves the location from MakeBucket request.

Fixes #273
harshavardhana pushed a commit to harshavardhana/minio-go that referenced this issue Dec 26, 2015
Additionally saves the location from MakeBucket request.

Fixes minio#273
harshavardhana pushed a commit to harshavardhana/minio-go that referenced this issue Dec 26, 2015
Additionally saves the location from MakeBucket request.

Fixes minio#273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants