Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header inconsistencies #303

Closed
krishnasrinivas opened this issue Jan 13, 2016 · 2 comments
Closed

header inconsistencies #303

krishnasrinivas opened this issue Jan 13, 2016 · 2 comments
Assignees

Comments

@krishnasrinivas
Copy link
Contributor

minio-go sends Accept-Encoding: gzip
is the correct behavior?

minio-go does not print response headers for PUT DELETE

@harshavardhana
Copy link
Member

minio-go sends Accept-Encoding: gzip

        // DisableCompression, if true, prevents the Transport from
        // requesting compression with an "Accept-Encoding: gzip"
        // request header when the Request contains no existing
        // Accept-Encoding value. If the Transport requests gzip on
        // its own and gets a gzipped response, it's transparently
        // decoded in the Response.Body. However, if the user
        // explicitly requested gzip it is not automatically
        // uncompressed.
        DisableCompression bool

Looks like a feature and we don't need to enable it.

@harshavardhana
Copy link
Member

golang/go#13942 , https://go-review.googlesource.com/#/c/18624/ - here is the fix for other issues.

harshavardhana pushed a commit to harshavardhana/minio-go that referenced this issue Jan 14, 2016
harshavardhana pushed a commit to harshavardhana/minio-go that referenced this issue Jan 14, 2016
harshavardhana pushed a commit to harshavardhana/minio-go that referenced this issue Jan 15, 2016
harshavardhana pushed a commit to harshavardhana/minio-go that referenced this issue Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants