Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for poo* and goo* #92

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Conversation

harshavardhana
Copy link
Member

No description provided.

krisis
krisis previously requested changes Jun 1, 2018
, pooUserMetadata :: [(Text, Text)]
-- | Control concurreny with setting this value to desried number.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could say "Number of worker threads used to upload an object"

, pooContentLanguage :: Maybe Text
-- | If you don't specify, Standard is the default storage class.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could say "Possible values are Standard and ReducedRedundancy. The storage class is Standard by default (i.e when Nothing is passed)."

, pooStorageClass :: Maybe Text
-- | Headers starting with this prefix are user-defined metadata.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Metadata to store with the object uploaded"

pooContentType :: Maybe Text
-- | Specifies what content encodings have been applied to the object and thus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should describe what this field is meant for and need not explain how Content-Encoding header works with Content-Type.

Copy link
Member Author

@harshavardhana harshavardhana Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what its meant for @krisis it doesn't work with incorrect content-type

@harshavardhana
Copy link
Member Author

PTAL @krisis @donatello

donatello
donatello previously approved these changes Jun 4, 2018
, pooContentLanguage :: Maybe Text
-- | Set to possible values are Standard and ReducedRedundancy. The
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "Set Storage class. Possible values are Standard and ReducedRedundancy ..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants