-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for poo* and goo* #92
Conversation
src/Network/Minio/Data.hs
Outdated
, pooUserMetadata :: [(Text, Text)] | ||
-- | Control concurreny with setting this value to desried number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could say "Number of worker threads used to upload an object"
src/Network/Minio/Data.hs
Outdated
, pooContentLanguage :: Maybe Text | ||
-- | If you don't specify, Standard is the default storage class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could say "Possible values are Standard and ReducedRedundancy. The storage class is Standard by default (i.e when Nothing is passed)."
src/Network/Minio/Data.hs
Outdated
, pooStorageClass :: Maybe Text | ||
-- | Headers starting with this prefix are user-defined metadata. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Metadata to store with the object uploaded"
src/Network/Minio/Data.hs
Outdated
pooContentType :: Maybe Text | ||
-- | Specifies what content encodings have been applied to the object and thus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should describe what this field is meant for and need not explain how Content-Encoding header works with Content-Type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is what its meant for @krisis it doesn't work with incorrect content-type
PTAL @krisis @donatello |
src/Network/Minio/Data.hs
Outdated
, pooContentLanguage :: Maybe Text | ||
-- | Set to possible values are Standard and ReducedRedundancy. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be "Set Storage class. Possible values are Standard and ReducedRedundancy ..."
No description provided.