Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All arguments for all functions should have native types #300

Closed
harshavardhana opened this issue Dec 1, 2015 · 2 comments
Closed

All arguments for all functions should have native types #300

harshavardhana opened this issue Dec 1, 2015 · 2 comments

Comments

@harshavardhana
Copy link
Member

For example in Golang in PresignedGetObject

func (a API) PresignedGetObject(bucket, object string, expires time.Duration) (string, error) {

Expires argument is time.Duration which is a native type under Golang ecosystem, we should make sure that wherever possible we should take native types.

harshavardhana added a commit to harshavardhana/minio-java that referenced this issue Jan 25, 2016
harshavardhana added a commit to harshavardhana/minio-java that referenced this issue Jan 25, 2016
harshavardhana added a commit to harshavardhana/minio-java that referenced this issue Jan 25, 2016
harshavardhana added a commit to harshavardhana/minio-java that referenced this issue Jan 25, 2016
@GarimaKapoor
Copy link

@harshavardhana is this still valid?

@harshavardhana
Copy link
Member Author

@harshavardhana is this still valid?

No it is not @GarimaKapoor - closing we have native types for all functions now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants