Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade shadow v6.1.0 #1115

Merged
merged 2 commits into from
Nov 15, 2020

Conversation

marcphilipp
Copy link
Contributor

This commit simplifies the publishing configuration by upgrading Shadow
to 6.1.0 and using Gradle's built-in javadocJar/sourcesJar tasks.

Fixes #1095.

This commit simplifies the publishing configuration by upgrading Shadow
to 6.1.0 and using Gradle's built-in javadocJar/sourcesJar tasks.
build.gradle Outdated Show resolved Hide resolved
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good

build.gradle Outdated Show resolved Hide resolved
@balamurugana balamurugana changed the title Upgrade to Shadow 6.1.0 build: upgrade shadow v6.1.0 Nov 15, 2020
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 9f9c9f9 into minio:master Nov 15, 2020
@marcphilipp marcphilipp deleted the 1095-upgrade-shadow-plugin branch November 16, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to figure out publishing plugin incompaibility with 6.0.0 shadow plugin
3 participants