Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint - Add environment variable RUN_ON_FAIL #1180

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

iternity-dotcom
Copy link
Contributor

Refering to https://github.com/minio/minio/issues/11996

Description

By setting the variable RUN_ON_FAIL all tests from minio-java are executed independent of failures.

Motivation and Context

A single failing test from the test package causes all the remaining tests to be skipped.

How to test this PR?

RUN_ON_FAIL=1
At least two tests must fail.

RUN_ON_FAIL=0
The behavior is not changed if the environment variable is not set or equals 0.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

functional/FunctionalTest.java Outdated Show resolved Hide resolved
functional/FunctionalTest.java Outdated Show resolved Hide resolved
@andrebruch andrebruch force-pushed the run-on-fail branch 3 times, most recently from 33f83cc to 9121fd7 Compare June 16, 2021 09:34
balamurugana
balamurugana previously approved these changes Jun 16, 2021
functional/FunctionalTest.java Outdated Show resolved Hide resolved
@harshavardhana harshavardhana merged commit 9d6094a into minio:master Jan 13, 2022
@rluetzner rluetzner deleted the run-on-fail branch June 3, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants