Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if unsupported okhttp3 is found. #1211

Merged

Conversation

balamurugana
Copy link
Member

As okhttp 4.x and 3.x use same package name okhttp3, minio-java
fails at middle of runtime if okhttp 3.x is used. This patch fails
at beginning if unsupported okhttp3 is found.

Signed-off-by: Bala.FA bala.gluster@gmail.com

As `okhttp` 4.x and 3.x use same package name `okhttp3`, `minio-java`
fails at middle of runtime if `okhttp` 3.x is used. This patch fails
at beginning if unsupported okhttp3 is found.

Signed-off-by: Bala.FA <bala.gluster@gmail.com>
@harshavardhana harshavardhana merged commit 9585da3 into minio:master Jul 19, 2021
@balamurugana balamurugana deleted the Fail-if-unsupported-okhttp3-is-found branch July 19, 2021 21:18
@odin568
Copy link

odin568 commented Jul 26, 2021

As a consequence using this libary against SpringBoot 2.5.3 (latest) causes (expected) exceptions:
Unsupported OkHttp library found. Must use okhttp >= 4.8.1

Dependency Versions: https://docs.spring.io/spring-boot/docs/current/reference/html/dependency-versions.html#

Upgrade to okhttp4 was rejected till now, don't know for when it is planned.
spring-projects/spring-boot#18506

Not sure if being so strict is a good idea. What is the reasoning behind?

@balamurugana
Copy link
Member Author

As a consequence using this libary against SpringBoot 2.5.3 (latest) causes (expected) exceptions:
Unsupported OkHttp library found. Must use okhttp >= 4.8.1

Dependency Versions: https://docs.spring.io/spring-boot/docs/current/reference/html/dependency-versions.html#

Upgrade to okhttp4 was rejected till now, don't know for when it is planned.
spring-projects/spring-boot#18506

Not sure if being so strict is a good idea. What is the reasoning behind?

As mentioned in the description of this PR, the failure happens if okhttp v3 is used. With this PR, you get an error in prior by custom error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants