-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use standard Objects class instead of Guava #1261
Conversation
All |
Even though, it is not possible to completely get rid of Guava, the PR looks good to me. Methods |
I have zero idea what Github Workflow is (yet :-)), but I'll try. |
Just add |
bb93674
to
0e162c6
Compare
@balamurugana Tell me if this is what you wanted. I had to 'negate' grep returning code, so I've made simple if based on https://github.com/actions/checkout/blob/main/.github/workflows/check-dist.yml#L40 Edit: OK, I forgot about ! operator. Now this is a one-liner. |
0e162c6
to
d30f889
Compare
Does this reduce the SDK size in some way? |
d30f889
to
6973468
Compare
Guava is still in use, so not really. |
b2a011c
to
ae9c6ea
Compare
ae9c6ea
to
7d7f898
Compare
Minimal Java version for the project seems to be 8 (
source\targetCompatibility = JavaVersion.VERSION_1_8
). There's no need to use Guava forequals
andhashCode
methods. I've changedcom.google.common.base.Objects
tojava.util.Objects
and this reduced number of imports from Guava by half.