Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3/4 of Gradle warnings #1273

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Conversation

Emkas
Copy link
Contributor

@Emkas Emkas commented Nov 28, 2021

When building a code there is warning:

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.6.1/userguide/command_line_interface.html#sec:command_line_warnings

I've corrected 3 of 4 problems. For the last one (changing compile for api/implementation/runOnly etc.) I'd need to know a project structure little better.

@harshavardhana
Copy link
Member

Please fix build issues @Emkas

6 actionable tasks: 1 executed, 5 up-to-date
Error: Exception in thread "main" java.lang.Exception: version does not match; expected=8.3.4-DEV, got=task ':api:jar' property 'archiveVersion'
	at TestUserAgent.main(TestUserAgent.java:45)
Error: Process completed with exit code 1.

@Emkas
Copy link
Contributor Author

Emkas commented Nov 28, 2021

Hmm... that's strange. I've ran build and functional tests without problems. Sorry for that. I'll look into it.

@Emkas
Copy link
Contributor Author

Emkas commented Nov 28, 2021

OK. I found out about TestUserAgent class. It's funny because this looks like it's connected to a Gradle's bug: gradle/gradle#14972. I've added .get() to this property and on my local machine TestUserAgent works.

@balamurugana balamurugana merged commit 41883a1 into minio:master Nov 29, 2021
@Emkas Emkas deleted the gradle-warnings branch November 29, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants