Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uploadSnowballObjects() method. #1277

Merged

Conversation

balamurugana
Copy link
Member

Signed-off-by: Bala.FA bala@minio.io

@balamurugana balamurugana marked this pull request as draft December 3, 2021 14:02
@balamurugana balamurugana force-pushed the Add-uploadSnowballObject-method branch from 2b88ad2 to d9d619f Compare December 3, 2021 17:30
@balamurugana balamurugana changed the title Add uploadSnowballObject() method. Add uploadSnowballObjects() method. Dec 3, 2021
@balamurugana balamurugana force-pushed the Add-uploadSnowballObject-method branch 5 times, most recently from 1e5bc6b to 53d7bd2 Compare December 4, 2021 11:03
@balamurugana balamurugana marked this pull request as ready for review December 4, 2021 11:16
@balamurugana balamurugana force-pushed the Add-uploadSnowballObject-method branch 2 times, most recently from 334423f to 6cf6821 Compare December 4, 2021 13:15
harshavardhana
harshavardhana previously approved these changes Dec 6, 2021
@balamurugana balamurugana force-pushed the Add-uploadSnowballObject-method branch from f12cb6b to 1ef8d8e Compare December 6, 2021 12:31
@klauspost
Copy link

Ah yeah, now I remember that it wasn't actually made streaming, but required size upfront: https://github.com/minio/minio/blob/be34fc9134156caa59efbaa69ea7ca8dae102d56/cmd/object-handlers.go#L1927

Makes it so much less useful.

@balamurugana balamurugana force-pushed the Add-uploadSnowballObject-method branch from 1ef8d8e to 01e1775 Compare December 6, 2021 13:53
Copy link

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, but it has literally been about 20 years since I stopped writing java.

Signed-off-by: Bala.FA <bala@minio.io>
@balamurugana balamurugana force-pushed the Add-uploadSnowballObject-method branch from be78d9e to ac1699d Compare January 5, 2022 01:30
@minio-trusted minio-trusted merged commit 57e34b7 into minio:master Jan 13, 2022
@balamurugana balamurugana deleted the Add-uploadSnowballObject-method branch January 13, 2022 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants