Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common-java:DuplicatedBlocks - Source files should not have any duplicated blocks #394

Merged
merged 1 commit into from
Jun 9, 2016
Merged

common-java:DuplicatedBlocks - Source files should not have any duplicated blocks #394

merged 1 commit into from
Jun 9, 2016

Conversation

georgekankava
Copy link

This pull request is focused on resolving occurrences of Sonar rule
common-java:DuplicatedBlocks - Source files should not have any duplicated blocks.
squid:MethodCyclomaticComplexity - Methods should not be too complex.
This pull request removes 54 minutes of technical debt.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/common-java:DuplicatedBlocks
https://dev.eclipse.org/sonar/rules/show/squid:MethodCyclomaticComplexity
Please let me know if you have any questions.
George Kankava

@balamurugana
Copy link
Member

Two trivial issues need to be fixed to pass travis.

1   /home/bala/java/src/github.com/minio-java/src/main/java/io/minio/Digest.java    166     An empty statement (semicolon) not part of a loop
2   /home/bala/java/src/github.com/minio-java/src/main/java/io/minio/Digest.java    167     An empty statement (semicolon) not part of a loop

error description is at http://pmd.sourceforge.net/pmd-5.2.3/pmd-java/rules/java/empty.html#EmptyStatementNotInLoop



private static long readBytes(int len,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment about this function.

…cated blocks

squid:MethodCyclomaticComplexity - Methods should not be too complex
@georgekankava
Copy link
Author

@balamurugana Updated

@balamurugana
Copy link
Member

👍 LGTM

@harshavardhana harshavardhana merged commit 3f47d83 into minio:master Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants