Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move InvalidArgumentException to IllegalArgumentException #861

Merged
merged 1 commit into from
Mar 8, 2020
Merged

move InvalidArgumentException to IllegalArgumentException #861

merged 1 commit into from
Mar 8, 2020

Conversation

balamurugana
Copy link
Member

This breaks backward compatibility.

sinhaashish
sinhaashish approved these changes Mar 8, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 9c9f2d1 into minio:master Mar 8, 2020
@balamurugana balamurugana deleted the move-InvalidArgumentException-to-IllegalArgumentException branch March 9, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinhaashish sinhaashish sinhaashish approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@nitisht nitisht Awaiting requested review from nitisht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @harshavardhana @sinhaashish