Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all deprecated methods and usage #862

Conversation

balamurugana
Copy link
Member

No description provided.

@balamurugana balamurugana force-pushed the remove-all-deprecated-methods-and-usage branch 4 times, most recently from fcad3da to e38d2e3 Compare March 9, 2020 05:27
Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine @balamurugana are you planning to update API.md as well?

@balamurugana
Copy link
Member Author

Changes look fine @balamurugana are you planning to update API.md as well?

There are many PRs change APIs. Updating API.md wouldn't be advised for this PR.

@balamurugana balamurugana force-pushed the remove-all-deprecated-methods-and-usage branch from e38d2e3 to 24713d8 Compare March 13, 2020 03:58
@kannappanr kannappanr self-requested a review March 14, 2020 01:44
@balamurugana balamurugana force-pushed the remove-all-deprecated-methods-and-usage branch 3 times, most recently from 427c712 to 652d934 Compare March 14, 2020 10:51
kannappanr
kannappanr previously approved these changes Mar 14, 2020
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the remove-all-deprecated-methods-and-usage branch from 25c6e00 to f1d2fd0 Compare March 15, 2020 10:53
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit e54bfc2 into minio:master Mar 15, 2020
@balamurugana balamurugana deleted the remove-all-deprecated-methods-and-usage branch March 15, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants