-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor removeBucket
#1177
Merged
Merged
refactor removeBucket
#1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakashsvmx
previously approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. 👍
Note: This operation will only work if your bucket is empty.
Callback style:
const bucketName = 'test-js-bucket-1'
s3Client.removeBucket(bucketName, function (e) {
if (e) {
return console.log(e.message)
}
console.log('Success')
})
Promise Style
s3Client
.removeBucket('test-bucket-1')
.then((res) => {
console.log('Result::', res)
})
.catch((err) => {
console.log('Error::', err.message)
})
Async/Await
const removeBucketTest = async () => {
try {
await s3Client.removeBucket(bucketName)
console.log('Success')
} catch (err) {
console.log(err.message)
}
}
removeBucketTest()
@trim21 could you please resolve the conflicts ? |
I didn't remove callback API overload as you did for |
prakashsvmx
approved these changes
Jul 6, 2023
@kaankabalak Could you please take a look ? |
kaankabalak
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.