SSE support for getObject #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannGit
force-pushed
the
feat/get-sse-object
branch
from
854a29e
to
f504301
Compare
prakashsvmx
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Thank you for the contribution @JohannGit . Could you check the comment ?
JohannGit
force-pushed
the
feat/get-sse-object
branch
from
6a98a2b
to
367d087
Compare
|
@prakashsvmx sorry CI were not successful cause I forgot to use prettier. |
# Conflicts: # src/internal/client.ts
JohannGit
force-pushed
the
feat/get-sse-object
branch
from
367d087
to
5845fbb
Compare
|
@prakashsvmx This is good, I fixed the last lint error (import sort) |
prakashsvmx
approved these changes
Jun 10, 2024
kaankabalak
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently minio-js has SSE support for putObject but not for getObject.
I had to do a npx patch for my project to support it, but I'll be glad if it's part of the minio-js directly.
This PR is related to very old issues but SSE support for getObject never reached master branch:
This PR brings the ability to give SSE headers to the getObject call via the metaData parameter, the same way putObject does.