cleanup: Add more documentation and cleanup. #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
pushed a commit
that referenced
this pull request
Dec 1, 2015
cleanup: Add more documentation and cleanup.
vsoch
added a commit
to researchapps/minio-py
that referenced
this pull request
Apr 6, 2020
In the case that the user wants to use the minio-py client to generate a presigned url, also in the case that a server is making a request on behalf of a command line client (where the object to be uploaded lives) this means that the command line client will need to send the sha256sum to the server (which is not able to calculate it). In practice I was attempting this workflow (singularity/sregistry PR minio#298) and getting an invalid signature every time. I figured out that the sha256sum was important because it was being sent to the server from the Singularity command line tool, and the trick was getting it into the function preload_v4 so that it would be included in the signature calculation. Once I was able to do this, my pre-signed urls for multipart upload worked like a charm! While I think it would be great for minio-py to have a fully supported function to generate these URLS more easily, in the meantime this small change to allow specifying the content_hash_hex will be useful to users that have similar use case to me Signed-off-by: vsoch <vsochat@stanford.edu>
vsoch
added a commit
to researchapps/minio-py
that referenced
this pull request
Apr 6, 2020
In the case that the user wants to use the minio-py client to generate a presigned url, also in the case that a server is making a request on behalf of a command line client (where the object to be uploaded lives) this means that the command line client will need to send the sha256sum to the server (which is not able to calculate it). In practice I was attempting this workflow (singularity/sregistry PR minio#298) and getting an invalid signature every time. I figured out that the sha256sum was important because it was being sent to the server from the Singularity command line tool, and the trick was getting it into the function preload_v4 so that it would be included in the signature calculation. Once I was able to do this, my pre-signed urls for multipart upload worked like a charm! While I think it would be great for minio-py to have a fully supported function to generate these URLS more easily, in the meantime this small change to allow specifying the content_hash_hex will be useful to users that have similar use case to me Signed-off-by: vsoch <vsochat@stanford.edu>
vsoch
added a commit
to researchapps/minio-py
that referenced
this pull request
Apr 7, 2020
In the case that the user wants to use the minio-py client to generate a presigned url, also in the case that a server is making a request on behalf of a command line client (where the object to be uploaded lives) this means that the command line client will need to send the sha256sum to the server (which is not able to calculate it). In practice I was attempting this workflow (singularity/sregistry PR minio#298) and getting an invalid signature every time. I figured out that the sha256sum was important because it was being sent to the server from the Singularity command line tool, and the trick was getting it into the function preload_v4 so that it would be included in the signature calculation. Once I was able to do this, my pre-signed urls for multipart upload worked like a charm! While I think it would be great for minio-py to have a fully supported function to generate these URLS more easily, in the meantime this small change to allow specifying the content_hash_hex will be useful to users that have similar use case to me Signed-off-by: vsoch <vsochat@stanford.edu>
vsoch
added a commit
to researchapps/minio-py
that referenced
this pull request
Apr 7, 2020
In the case that the user wants to use the minio-py client to generate a presigned url, also in the case that a server is making a request on behalf of a command line client (where the object to be uploaded lives) this means that the command line client will need to send the sha256sum to the server (which is not able to calculate it). In practice I was attempting this workflow (singularity/sregistry PR minio#298) and getting an invalid signature every time. I figured out that the sha256sum was important because it was being sent to the server from the Singularity command line tool, and the trick was getting it into the function preload_v4 so that it would be included in the signature calculation. Once I was able to do this, my pre-signed urls for multipart upload worked like a charm! While I think it would be great for minio-py to have a fully supported function to generate these URLS more easily, in the meantime this small change to allow specifying the content_hash_hex will be useful to users that have similar use case to me Signed-off-by: vsoch <vsochat@stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.