tests: Add support for functional tests to run in mint. #547
Conversation
harshavardhana
force-pushed
the
mint
branch
3 times, most recently
from
505c764
to
5302134
Compare
tests/functional/tests.py
Outdated
| # return empty bytes to indicate EOF. | ||
| return b'' | ||
|
|
||
| data = b''.join([b'o' for i in range(amt)]) |
There was a problem hiding this comment.
this doesn't look like random data.
There was a problem hiding this comment.
My bad..local change is not pushed.
tests/functional/tests.py
Outdated
| metadata={'x-amz-storage-class': 'STANDARD_IA'}) | ||
|
|
||
| # Fput a large file. | ||
| print("Upload a largfile through multipart upload") |
|
@harshavardhana does this also address #548 ? |
Yes it does @nitisht |
|
Changed a bunch of things, added more randomness as asked by @krisis . Please take a look again. |
tests/functional/tests.py
Outdated
|
|
||
| # make translation table from 0..255 to 97..122 | ||
| bal = [c.encode('ascii') for c in ascii_lowercase] | ||
| data = b''.join([bal[int(random() * 26)] for _ in range(amt)]) |
There was a problem hiding this comment.
As a consequence to the previous comment, we should compute the remaining bytes to be returned.
amt = min(amt, self._limit - self._offset_location)
tests/functional/tests.py
Outdated
| How much of the content to read. | ||
| """ | ||
| # If offset is bigger than size. Treat it as EOF return here. | ||
| if self._offset_location + amt > self._limit: |
There was a problem hiding this comment.
we should return empty bytes (b'') only when self._offset_location == self._limit. E.g, when
self._limit = 10, self._offset = 9 and amt = 5, we should return the last byte and not b''.
|
For path APIs we need local files. Streaming is only for generating content for streaming APIs |
|
@harshavardhana IIUC, we are running file based object operations (like FPutObject) inside mint environment and stream-based object operations outside of mint environment. Shouldn't we run all kinds of operations in both environments? |
Yes ideally, but there seems to be some confusing aspects floating around on the nature of functional tests themselves. Should be used to test SDK or server and what is their rightful place. Updated the PR as well to provide mint as a sub-set behavior only meant to be used as data dir location. If not we auto-generate this data such that some APIs are not skipped on regular testing without mint. |
This PR is needed to support multiple environments in which the following test script will be run. Re-purpose the limit reader and make it a random reader.
This PR is needed to support multiple environments in
which the following test script will be run.