Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the failing functional test cases for s3 #713

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

Praveenrajmani
Copy link
Collaborator

This PR fixes the following functional test cases which were failing on s3

  • test_put_object
  • test_stat_object

Taking into account that, metadata can be case-insensitive, the metadata is normalized for test cases so that it could work for both s3 and minio. Minio responds with canonicalized metadata, but s3 does not.

Fixes #709

- test_put_objecy
- test_stat_object

Fixes minio#709
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vadmeste
Copy link
Member

@Praveenrajmani you have a travis error which can go away if you rebase with master

Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deekoder deekoder merged commit a27fa1e into minio:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functional test: minio-py while running in mint should exit on failure
4 participants