Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces Minio refs with MinIO and minio.io links with min.io #750

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Replaces Minio refs with MinIO and minio.io links with min.io #750

merged 3 commits into from
Apr 9, 2019

Conversation

kannappanr
Copy link
Collaborator

Replace minio.io with min.io and Minio with MinIO

PR is based on #749

ebozduman
ebozduman previously approved these changes Apr 8, 2019
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sinhaashish
sinhaashish suggested changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look

  1. https://github.com/kannappanr/minio-py/blob/a0fa95ab43d1bc0048ead41e1106129f1ff74de6/examples/progress.py#L18

Praveenrajmani
Praveenrajmani reviewed Apr 8, 2019
View reviewed changes
examples/progress.py Outdated Show resolved Hide resolved
sinhaashish
sinhaashish approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit a1f4ac7 into minio:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praveenrajmani Praveenrajmani Praveenrajmani approved these changes

@sinhaashish sinhaashish sinhaashish approved these changes

@ebozduman ebozduman ebozduman left review comments

Assignees
No one assigned
Labels
priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kannappanr @Praveenrajmani @sinhaashish @ebozduman @nitisht