Use Credentials (similar to minio-go) to enable AWS IAM #817

febg · 2019-10-29T02:38:03Z

First attempt to fix #814 it gives an idea about the design and how I tried to follow the minio-go implementation

febg · 2019-11-05T03:57:47Z

@harshavardhana Any updates on feedback for this?

harshavardhana · 2019-11-05T04:38:42Z

Not yet, we are currently busy with other priorities we will get back to you soon @febg

hootener · 2019-11-19T15:23:15Z

@harshavardhana This PR was submitted by the Codecov team. We make frequent use of this library in our Enterprise product and would love to bring minio-py's credential management code up to par with other minio SDK implementations (go, etc.).

We actively field minio (and minio-py) as a storage interface solution for Codecov Enterprise to some of our largest enterprise clients. We're submitting this PR on their behalf as AWS IAM support is routinely cited as a bottleneck to minio adoption by these companies. Is there anything we can do on our end to help expedite the review of this PR? Happy to help in any way we can.

harshavardhana · 2019-11-19T17:33:32Z

@hootener there is nothing you need to do, we internally are neck deep busy with some deliverables and haven't found sufficient time to spend on this.

We would need a minimum of another 3 weeks before we can review this PR unfortunately.

hootener · 2019-11-19T18:10:19Z

@harshavardhana That's fine.

Even the ballpark estimate of when work can start gives me something to take back. So I'll let other stakeholders know there's at least a three week backlog before this can be reviewed. I'll check back for traction on this PR then. Thanks.

minio/api.py

minio/credentials/aws_iam.py

minio/credentials/file_aws_credentials.py

harshavardhana · 2019-12-19T22:10:34Z

@febg can you get this PR out of WIP and ready for final review? or do you wish to iterate on this further?

febg · 2019-12-19T23:39:13Z

@harshavardhana @devgrok should be ready for final review! Thanks!

vadmeste

Some comments, not tested yet

minio/api.py

minio/credentials/file_minio_client.py

Praveenrajmani · 2020-01-02T12:18:55Z

@febg Can you add an example in examples/ folder?

febg · 2020-01-02T22:46:31Z

@Praveenrajmani should I add one example per every credentials provider?

Eg.

aws_iam_crendentials_example
chain_credentials_example
env_minio_credentials_example
file_minio_credentials_example
env_aws_credentials_example
etc...?

I was thinking on only doing aws_iam_crendentials and chain_credentials examples since it gets repetitive and it is quite intuitive

harshavardhana · 2020-01-02T23:31:14Z

@Praveenrajmani @febg two examples should be enough for now.

minio/api.py

…fb_credentials

Praveenrajmani

If we are not supporting IMDSv2, can we mention that in the docs? Or validate the version if possible @febg? LGTM otherwise

febg · 2020-01-10T19:32:46Z

@devgrok I applied your patch! Thanks for figuring it out!

Praveenrajmani

LGTM

Praveenrajmani · 2020-01-22T08:31:35Z

PTAL @vadmeste @harshavardhana

harshavardhana

Apart from license header fixes the rest of the PR LGTM - thanks for your patience @febg - we really appreciate all the work 🍰

examples/aws_credentials.py

examples/chain_credentials.py

minio/credentials/__init__.py

minio/credentials/aws_iam.py

minio/credentials/chain.py

minio/credentials/static.py

tests/unit/chain_provider_test.py

tests/unit/credentials_test.py

tests/unit/env_aws_provider_test.py

tests/unit/env_minio_provider_test.py

febg-codecov added 6 commits October 24, 2019 13:00

Added aws, minio, iam, chain and static credentials

08ae6aa

Added aws, minio, iam, chain and static credentials

cd1da0c

Merged conflicts

5396830

Fixed white spaces

26e603a

Added credentials to api.py and sginer.py

ea63277

Removed signer_type from providers

6a64b5c

febg mentioned this pull request Oct 29, 2019

Use Credentials (similar to minio-go) to enable AWS IAM #814

Closed

febg-codecov added 3 commits November 4, 2019 18:39

Resolved conflicts

c268a1b

Fixed signv4 test

9b7579f

Added credentials to setup.py

43d2225

devgrok reviewed Dec 16, 2019

View reviewed changes

minio/api.py Outdated Show resolved Hide resolved

minio/credentials/aws_iam.py Outdated Show resolved Hide resolved

minio/credentials/file_aws_credentials.py Show resolved Hide resolved

febg-codecov added 3 commits December 19, 2019 17:43

Review changes

6932c4b

Added empty credentials file

fd90d4f

Merge branch 'master' into fb_credentials

7a2ed50

febg changed the title ~~[WIP] Use Credentials (similar to minio-go) to enable AWS IAM~~ Use Credentials (similar to minio-go) to enable AWS IAM Dec 19, 2019

febg-codecov added 3 commits December 19, 2019 17:55

Added python 2 compatibility

1069511

Fixed abc bug

a821cf4

added configparser dependency for python 2

e91b73c

kannappanr requested review from vadmeste and Praveenrajmani December 20, 2019 00:11

vadmeste reviewed Dec 23, 2019

View reviewed changes

minio/api.py Outdated Show resolved Hide resolved

minio/credentials/file_minio_client.py Outdated Show resolved Hide resolved

febg-codecov and others added 2 commits January 3, 2020 09:58

Added fixes and examples

62e9e1e

Merge branch 'master' into fb_credentials

7466e99

febg requested review from vadmeste and harshavardhana January 3, 2020 17:31

devgrok reviewed Jan 4, 2020

View reviewed changes

minio/api.py Show resolved Hide resolved

febg-codecov added 2 commits January 8, 2020 18:16

removed IamEc2MetaData from init chain provider

599058c

Merge branch 'fb_credentials' of github.com:felipeball/minio-py into …

3331f17

…fb_credentials

Praveenrajmani previously approved these changes Jan 9, 2020

View reviewed changes

applied devgrok patch

2ec7ce8

febg dismissed Praveenrajmani’s stale review via 2ec7ce8 January 10, 2020 19:29

febg requested a review from Praveenrajmani January 10, 2020 19:31

Praveenrajmani previously approved these changes Jan 22, 2020

View reviewed changes

harshavardhana requested changes Jan 22, 2020

View reviewed changes

fixed license

f6444c8

febg dismissed Praveenrajmani’s stale review via f6444c8 January 23, 2020 00:10

harshavardhana approved these changes Jan 23, 2020

View reviewed changes

harshavardhana merged commit c5d66fc into minio:master Jan 23, 2020

animeshsingh mentioned this pull request Jan 28, 2020

Replace minio library with boto3 for S3 access kserve/kserve#628

Closed

juhoautio mentioned this pull request Jun 30, 2021

AWS credentials provider with role_arn + source_profile #1119

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Credentials (similar to minio-go) to enable AWS IAM #817

Use Credentials (similar to minio-go) to enable AWS IAM #817

febg commented Oct 29, 2019

febg commented Nov 5, 2019

harshavardhana commented Nov 5, 2019

hootener commented Nov 19, 2019

harshavardhana commented Nov 19, 2019

hootener commented Nov 19, 2019

harshavardhana commented Dec 19, 2019

febg commented Dec 19, 2019

vadmeste left a comment

Praveenrajmani commented Jan 2, 2020

febg commented Jan 2, 2020

harshavardhana commented Jan 2, 2020

Praveenrajmani left a comment •

edited

Loading

febg commented Jan 10, 2020

Praveenrajmani left a comment

Praveenrajmani commented Jan 22, 2020

harshavardhana left a comment

Use Credentials (similar to minio-go) to enable AWS IAM #817

Use Credentials (similar to minio-go) to enable AWS IAM #817

Conversation

febg commented Oct 29, 2019

febg commented Nov 5, 2019

harshavardhana commented Nov 5, 2019

hootener commented Nov 19, 2019

harshavardhana commented Nov 19, 2019

hootener commented Nov 19, 2019

harshavardhana commented Dec 19, 2019

febg commented Dec 19, 2019

vadmeste left a comment

Choose a reason for hiding this comment

Praveenrajmani commented Jan 2, 2020

febg commented Jan 2, 2020

harshavardhana commented Jan 2, 2020

Praveenrajmani left a comment • edited Loading

Choose a reason for hiding this comment

febg commented Jan 10, 2020

Praveenrajmani left a comment

Choose a reason for hiding this comment

Praveenrajmani commented Jan 22, 2020

harshavardhana left a comment

Choose a reason for hiding this comment

Praveenrajmani left a comment •

edited

Loading