IAMProvider accepts ECS IAM Task roles #960
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this issue #956
This PR adds the
is_ecs_task
arg toIAMProvider
. When it is set toTrue
, it follows a slightly different URL path to get credentials.If you run a task on AWS ECS without a given task role, then
curl http://169.254.170.2$AWS_CONTAINER_CREDENTIALS_RELATIVE_URI
from within the container return a404
error, and this would be caught by the error handling already in this class.This would also require updates to the documentation on
IAMProvider
.Since
AWS_CONTAINER_CREDENTIALS_RELATIVE_URI
is so long, the 80-char line limit was challenging :)I have verified this works in an ECS task with an IAM role with: