Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add {set,get,delete}_bucket_replication APIs. #979

Conversation

balamurugana
Copy link
Member

No description provided.

@balamurugana balamurugana marked this pull request as draft September 28, 2020 13:01
@balamurugana balamurugana force-pushed the add-set-get-delete_bucket_replication-apis branch 2 times, most recently from 9110827 to a684dce Compare September 29, 2020 09:13
@balamurugana balamurugana marked this pull request as ready for review September 29, 2020 09:20
@balamurugana balamurugana force-pushed the add-set-get-delete_bucket_replication-apis branch from a684dce to 752d92e Compare September 29, 2020 15:53
BigUstad
BigUstad previously approved these changes Sep 29, 2020
Copy link

@BigUstad BigUstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the add-set-get-delete_bucket_replication-apis branch 3 times, most recently from 39519c2 to fc52dc9 Compare September 30, 2020 09:41
@@ -0,0 +1,81 @@
# -*- coding: utf-8 -*-
# MinIO Python Library for Amazon S3 Compatible Cloud Storage,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the license headers in few files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Collaborator

@Praveenrajmani Praveenrajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@balamurugana balamurugana force-pushed the add-set-get-delete_bucket_replication-apis branch 2 times, most recently from 4493e7f to c1b52e8 Compare September 30, 2020 13:42
Copy link

@BigUstad BigUstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana merged commit 643dc04 into minio:master Oct 13, 2020
@balamurugana balamurugana deleted the add-set-get-delete_bucket_replication-apis branch October 13, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants