Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to pkg@v1.7.3 to support aws:kms string in policy conditions #17414

Merged
merged 1 commit into from
Jun 14, 2023
Merged

move to pkg@v1.7.3 to support aws:kms string in policy conditions #17414

merged 1 commit into from
Jun 14, 2023

Conversation

harshavardhana
Copy link
Member

Description

move to pkg@v1.7.3 to support aws:kms string in policy conditions

Motivation and Context

commit 5c337c70fc8198ee87c188e6c4104210842e3921
Author: Harshavardhana <harsha@minio.io>
Date:   Sun Jun 11 20:48:47 2023 -0700

    allow 'aws:kms' for string conditionals (#68)

This is to take this support in

How to test this PR?

Nothing special however a policy with x-amz-server-side-encryption: "aws:kms" must be allowed for conditions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

vadmeste
vadmeste approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 69f819e into minio:master Jun 14, 2023
@harshavardhana harshavardhana deleted the add-support branch June 14, 2023 14:42
@ravindk89 ravindk89 mentioned this pull request Jun 19, 2023
Open
6 tasks
@bh4t bh4t added the bugfix label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@klauspost klauspost klauspost approved these changes

@kannappanr kannappanr Awaiting requested review from kannappanr

@poornas poornas Awaiting requested review from poornas

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshavardhana @vadmeste @klauspost @bh4t