add missing proper error return in WalkDir() #18884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this the caller might end up returning incorrect errors and not ignoring the drive properly.
harshavardhana
requested review from
vadmeste,
krisis,
klauspost and
kannappanr
harshavardhana
added
priority: high
next-release
kannappanr
approved these changes
Jan 27, 2024
klauspost
reviewed
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
add missing proper error return in WalkDir()
Motivation and Context
without this, the caller might end up returning
incorrect errors and not ignoring the drive
properly.
fixes #18858
How to test this PR?
You need a disk to go down right when an active
List() is in progress; testing is racy and more
challenging. But we have seen
mintCI/CD returnthese errors.
Refer #18858
Types of changes
Checklist:
commit-idorPR #here)