Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ssl only when set via environment variables #110

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Enable ssl only when set via environment variables #110

merged 1 commit into from
Aug 4, 2017

Conversation

nitisht
Copy link
Contributor

@nitisht nitisht commented Aug 2, 2017

aws-sdk-ruby tests set http.use_ssl = true for tests, this caused failure if the minio server was not set up with TLS.

ebozduman
ebozduman approved these changes Aug 2, 2017
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit feb97f6 into minio:master Aug 4, 2017
@nitisht nitisht deleted the aws-sdk-ruby branch August 4, 2017 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebozduman ebozduman ebozduman approved these changes

@deekoder deekoder deekoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitisht @deekoder @ebozduman