Ignore exceptions during cleanup #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebozduman
requested changes
Sep 29, 2017
| @@ -987,7 +991,6 @@ function runTest($s3Client, $myfunc, $fnSignature, $args = []) { | |||
| if ($errorCode != "NotImplemented") { | |||
| $status = "FAIL"; | |||
| $error = $e->getMessage(); | |||
| throw $e; | |||
There was a problem hiding this comment.
These tests, IMHO, cannot be considered as failures.
I think we may want to set the status field to NA instead of FAIL for APIs not implemented yet and instead of error, we can use alert field, that's the purpose of this field if I understand it correctly when we decided the purpose of these fields, for the meaningful message.
krisis
force-pushed
the
bug/logfailure
branch
from
4332dc5
to
84641c2
Compare
Exit process on first failure in place throwing an exception.
krisis
force-pushed
the
bug/logfailure
branch
from
84641c2
to
393ea47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit process on first failure in place throwing an exception.