Use correct minio-java version in test run phase #187
Conversation
nitisht
changed the title
run/core/minio-java/run.sh
Outdated
| MINIO_JAVA_VERSION="3.0.7" | ||
| MINIO_JAVA_PATH="/mint/run/core/minio-java" | ||
| MINIO_JAVA_PATH="$MINT_RUN_CORE_DIR/minio-java" | ||
| MINIO_JAVA_VERSION=$(curl -s https://api.github.com/repos/minio/minio-java/releases/latest | jq -r .tag_name) |
There was a problem hiding this comment.
This fix won't work if docker image has lower version of jar files and higher version available in github
There was a problem hiding this comment.
Docker image with get the jar file using same mechanism in install.sh, so how it will have lower version?
There was a problem hiding this comment.
While running docker image, you fetch version information from github which would return different version than the one available inside the image.
There was a problem hiding this comment.
ah..yes.good point..will update
run/core/minio-java/run.sh
Outdated
| @@ -15,8 +15,13 @@ | |||
| # limitations under the License. | |||
| # | |||
|
|
|||
| MINIO_JAVA_VERSION="3.0.7" | |||
| MINIO_JAVA_PATH="/mint/run/core/minio-java" | |||
| MINIO_JAVA_PATH="$MINT_RUN_CORE_DIR/minio-java" | |||
There was a problem hiding this comment.
MINT_RUN_CORE_DIR is not at all available globally.
There was a problem hiding this comment.
yes, will remove this
Agreed, this should work. Will change to this |
This is not working, path to exact jar file is needed. |
nitisht
force-pushed
the
minio-java-failure
branch
from
4b63fec
to
6c002bb
Compare
|
Updated with different approach @balamurugana please check. |
nitisht
force-pushed
the
minio-java-failure
branch
2 times, most recently
from
e1e24c6
to
61048a9
Compare
run/core/minio-java/run.sh script should use the minio-java version downloaded during build phase to run minio-java tests fixes minio#186
nitisht
force-pushed
the
minio-java-failure
branch
from
61048a9
to
5e7479e
Compare
nitisht
changed the title
|
Tested with this build, works fine Running with
SERVER_ENDPOINT: 127.0.0.1:9000
ACCESS_KEY: minio
SECRET_KEY: ***REDACTED***
ENABLE_HTTPS: 0
SERVER_REGION: us-east-1
MINT_DATA_DIR: /mint/data
MINT_MODE: core
To get intermittent logs, 'sudo docker cp 8136b886d1f3:/mint/log /tmp/mint-logs'
Running aws-sdk-php tests ... done in 41 seconds
Running aws-sdk-ruby tests ... done in 1 seconds
Running awscli tests ... done in 22 seconds
Running mc tests ... done in 4 seconds
Running minio-go tests ... done in 21 seconds
Running minio-java tests ... done in 6 seconds
Running minio-js tests ... done in 23 seconds
Running minio-py tests ... done in 10 seconds
Running s3cmd tests ... done in 7 seconds
Finished running all tests.
To get logs, run 'sudo docker cp 8136b886d1f3:/mint/log /tmp/mint-logs' |
run/core/minio-java/run.sh script should use the minio-java version
downloaded during build phase to run minio-java tests
fixes #186