fix regression in mint, with no args run all tests #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
changed the title
mint.sh
Outdated
| exit 1 | ||
| fi | ||
|
|
||
| for sdk in "$@"; do |
There was a problem hiding this comment.
What is the problem with current code?
There was a problem hiding this comment.
Multiple
docker run --rm --net=host -e ACCESS_KEY=minio -e SECRET_KEY=minio123 -e SERVER_ENDPOINT=localhost:9000 -e ENABLE_HTTPS=0 -e MINT_MODE=full minio/mint:edge
Running with
SERVER_ENDPOINT: localhost:9000
ACCESS_KEY: minio
SECRET_KEY: ***REDACTED***
ENABLE_HTTPS: 0
SERVER_REGION: us-east-1
MINT_DATA_DIR: /mint/data
MINT_MODE: full
To get logs, run 'docker cp 4a78fcfd8528:/mint/log /tmp/mint-logs'
All tests ran successfully
Doesn't run any tests.
docker run --rm --net=host -e ACCESS_KEY=minio -e SECRET_KEY=minio123 -e SERVER_ENDPOINT=localhost:9000 -e ENABLE_HTTPS=0 -e MINT_MODE=full minio/mint:edge aws-sdk-go
Running with
SERVER_ENDPOINT: localhost:9000
ACCESS_KEY: minio
SECRET_KEY: ***REDACTED***
ENABLE_HTTPS: 0
SERVER_REGION: us-east-1
MINT_DATA_DIR: /mint/data
MINT_MODE: full
To get logs, run 'docker cp 87cafdefd031:/mint/log /tmp/mint-logs'
(1/13) Running aws-sdk-go tests ... done in 0 seconds
(2/13) Running aws-sdk-java tests ... done in 2 seconds
(3/13) Running aws-sdk-php tests ...
If an argument is provided seems to run all tests...
mint.sh
Outdated
| sdks=( "$@" ) | ||
|
|
||
| ## populate all sdks except worm when no argument is given. | ||
| if [ "$#" -eq 1 ]; then |
There was a problem hiding this comment.
Fix this line. [ "$#" -eq 0 ]
There was a problem hiding this comment.
I tested locally with this fix only, i.e. if [ "$#" -eq 0 ] , mint behaves as expected.
There was a problem hiding this comment.
Will make that change
nitisht
approved these changes
Jun 15, 2018
|
since @harshavardhana has made the changes requested by @balamurugana and @nitisht has approved, merging this for minio/minio pending prs merges to progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.