Add aws-sdk-php tests to mint #48
Conversation
krisis
force-pushed
the
issue/38
branch
3 times, most recently
from
eca65b9
to
9cf0110
Compare
krisis
changed the title
run/core/aws-sdk-php/quick-tests.php
Outdated
|
|
||
| class ClientConfig { | ||
| public $creds; | ||
| public $endpoint = "https://play.minio.io:9000"; |
There was a problem hiding this comment.
Endpoint always play server?
There was a problem hiding this comment.
No, we are setting play as default endpoint. Now that I have a constructor taking $host as a parameter, I can remove this initialization.
There was a problem hiding this comment.
Removed assigning default value to $endpoint.
run/core/aws-sdk-php/run.sh
Outdated
| @@ -0,0 +1,34 @@ | |||
| #!/usr/bin/env bash | |||
| #!/usr/bin/expect -f | |||
run/core/aws-sdk-php/run.sh
Outdated
| #!/usr/bin/env bash | ||
| #!/usr/bin/expect -f | ||
| # | ||
| # Minio Cloud Storage, (C) 2017 Minio, Inc. |
build/php/aws-sdk-php.sh
Outdated
| } | ||
|
|
||
| # Install PHP dependencies | ||
| installAwsSdkPhpDeps() { |
There was a problem hiding this comment.
it would be good to rename this function as installDeps for consistency. The script name makes it clear it is for aws-sdk-php
krisis
force-pushed
the
issue/38
branch
3 times, most recently
from
4f72e41
to
5c91576
Compare
|
@poornas can you pls check again? Looks like comments we addressed |
|
@krisis I would suggest to create random bucket name during |
Partially addresses requirements in #38.