Update aws-cli and mc tests to use data-dir
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
Jun 28, 2017
run.sh
Outdated
| @@ -1,6 +1,6 @@ | |||
| #!/bin/bash | |||
| # | |||
| # Minio Cloud Storage, (C) 2017 Minio, Inc. | |||
| # Mint, (C) 2017 Minio, Inc. | |||
run.sh
Outdated
| @@ -55,6 +55,7 @@ _init() { | |||
| if [ -z "$DATA_DIR" ]; then | |||
| export DATA_DIR="/mint/data" | |||
| fi | |||
|
|
|||
There was a problem hiding this comment.
Stray new line not needed.
run/core/mc/test.sh
Outdated
| @@ -1,6 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
| # | |||
| # Minio Cloud Storage, (C) 2017 Minio, Inc. | |||
| # Mint, (C) 2017 Minio, Inc. | |||
run/core/mc/test.sh
Outdated
| # Make bucket | ||
| ./mc mb target/$bucketName | ||
| ./mc mb target/"${bucketName}" |
There was a problem hiding this comment.
Put "target/" inside the quotes as well.
run/core/mc/test.sh
Outdated
|
|
||
| echo "Testing if the bucket was created" | ||
| # list buckets | ||
| ./mc ls target | ||
|
|
||
| echo "Removing the bucket" | ||
| # remove bucket | ||
| ./mc rm target/$bucketName | ||
| ./mc rm target/"${bucketName}" |
nitisht
force-pushed
the
refactor-data-dir
branch
from
0cf4174
to
e5903b7
Compare
|
Updated. |
harshavardhana
requested changes
Jun 28, 2017
build/data/install.sh
Outdated
| createData () { | ||
| # if no data directory passed from out side, create data directory and populate. else use the data directory from outside | ||
| if [ ! -d $data_dir ]; then | ||
| mkdir $data_dir |
There was a problem hiding this comment.
This tabbing is off @nitisht need to see what text editor you are using.
poornas
reviewed
Jun 28, 2017
build/data/install.sh
Outdated
| data_dir="/mint/data" | ||
| } | ||
|
|
||
| createData () { |
nitisht
force-pushed
the
refactor-data-dir
branch
from
e5903b7
to
5df1e83
Compare
- Update dockerfile
nitisht
force-pushed
the
refactor-data-dir
branch
from
5df1e83
to
b5037a1
Compare
|
Fixed review comments. |
harshavardhana
approved these changes
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dockerfile and Readme