First commit to bring aws-sdk-ruby tests in mint. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deekoder
force-pushed
the
aws-ruby
branch
2 times, most recently
from
730aff8
to
c2593c2
Compare
poornas
requested changes
Jul 1, 2017
build/ruby/install.sh
Outdated
| apt-get update && \ | ||
| apt-get install -y ruby ruby-dev ruby-bundler && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
build/ruby/install.sh
Outdated
| } | ||
|
|
||
| main() { | ||
| # Start with installing python3. |
| access_key_id = ENV['ACCESS_KEY'] ||= 'ACESS_KEY is not set' | ||
| secret_access_key = ENV['SECRET_KEY'] ||= 'SECRET_KEY is not set' | ||
| data_dir = ENV['DATA_DIR'] ||= 'DATA_DIR is not set' | ||
| enable_https = ENV['ENABLE_HTTPS'] |
There was a problem hiding this comment.
wouldn't all credentials default to play.minio.io if not set?
There was a problem hiding this comment.
if its not set for some reason, this string would help in easy debugging.
| endpoint = 'http://' + endpoint | ||
| end | ||
|
|
||
| puts endpoint |
build/ruby/aws-ruby.sh
Outdated
| ruby --version | ||
| } | ||
|
|
||
| # Install PY dependencies |
| end | ||
| rescue | ||
| puts "Bucket Delete Test Fails" | ||
| end |
There was a problem hiding this comment.
indentation seems to be off on this file. Is begin/end blocks better vs methods? If you were to add more checks for boundary conditions for each API, this would read better if each test is in its own method.
deekoder
force-pushed
the
aws-ruby
branch
4 times, most recently
from
b5989c5
to
521f5f8
Compare
harshavardhana
approved these changes
Jul 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.