Adds first AWS-SDK Ruby tests #73
Conversation
| end | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
We should comment each of the tests..about what they do.
There was a problem hiding this comment.
Harsha,
Will do.
I thought the names of the methods are clear enough to explain what they do.
|
@ebozduman can you pls take a look at @harshavardhana review comments. |
| end | ||
|
|
||
|
|
||
| def list_buckets_test(s3Resource, s3Client) |
There was a problem hiding this comment.
Is the ruby format tabbing here appropriate? like previous defs are of the wrong alignment than this test..
There was a problem hiding this comment.
Good point. I also noticed that.
I am working on it.
| print_logn("- Success!") | ||
| print_status(state, e) | ||
| end | ||
| end | ||
|
|
||
| region = ENV['SERVER_REGION'] ||= 'SERVER_REGION not set' |
There was a problem hiding this comment.
Minor suggestion since everything else is in a def. This could also be in a def called validate. And endpoint generation could be also in a def. But i am ok with this to be improved next iteration. So LGTM for me.
|
@harshavardhana can you pls check this |
Adds the following AWS SDK Ruby tests: