-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pull tests from minio-go sdk #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually lets not add this .. until we make a release and we can pick from the release tag instead.
Can we unblock this by a |
We will do soon @nitisht |
This is taking longer than expected, i guess we can merge and change this later? |
@poornas tested locally against latest release, looks like tests failed, also there is no input in output.log
|
updated PR to use release tags - @nitisht , the output log is being written to error.log above because logrus by default writes to stderr. Sent a PR to fix default output for logger in minio-go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests running fine, logs are still getting populated in error.log
but that will be fixed after next minio-go release.
@poornas can you please file an issue to update to new minio-go
as we make a release after merging minio/minio-go#786
Fixes #89 - delete functional test copy on mint, and use the functional tests on minio-go sdk.