Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull tests from minio-go sdk #92

Merged
merged 1 commit into from
Aug 15, 2017
Merged

pull tests from minio-go sdk #92

merged 1 commit into from
Aug 15, 2017

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Jul 12, 2017

Fixes #89 - delete functional test copy on mint, and use the functional tests on minio-go sdk.

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually lets not add this .. until we make a release and we can pick from the release tag instead.

@nitisht
Copy link
Contributor

nitisht commented Jul 25, 2017

Can we unblock this by a minio-go release?

@harshavardhana
Copy link
Member

Can we unblock this by a minio-go release?

We will do soon @nitisht

@harshavardhana
Copy link
Member

This is taking longer than expected, i guess we can merge and change this later?

@nitisht nitisht removed the blocked label Aug 5, 2017
@nitisht
Copy link
Contributor

nitisht commented Aug 7, 2017

@poornas tested locally against latest release, looks like tests failed, also there is no input in output.log

$ cat error.log 
time="2017-08-07T13:13:03Z" level=info msg="Running functional tests for minio-go sdk...." file=functional_tests.go function:=main.main line#=4072
time="2017-08-07T13:13:03Z" level=info file=functional_tests.go function:=main.testMakeBucketErrorV2 line#=2403
time="2017-08-07T13:13:03Z" level=info msg="skipping region functional tests for non s3 runs" file=functional_tests.go function:=main.testMakeBucketErrorV2 line#=2405
time="2017-08-07T13:13:03Z" level=info file=functional_tests.go function:=main.testGetObjectClosedTwiceV2 line#=2451
time="2017-08-07T13:13:03Z" level=info file=functional_tests.go function:=main.testRemovePartiallyUploadedV2 line#=2529
time="2017-08-07T13:13:03Z" level=info file=functional_tests.go function:=main.testFPutObjectV2 line#=2596
time="2017-08-07T13:13:03Z" level=info file=functional_tests.go function:=main.testMakeBucketRegionsV2 line#=2743
time="2017-08-07T13:13:03Z" level=info msg="skipping region functional tests for non s3 runs" file=functional_tests.go function:=main.testMakeBucketRegionsV2 line#=2745
time="2017-08-07T13:13:03Z" level=info file=functional_tests.go function:=main.testGetObjectReadSeekFunctionalV2 line#=2796
time="2017-08-07T13:13:03Z" level=info file=functional_tests.go function:=main.testGetObjectReadAtFunctionalV2 line#=2926
time="2017-08-07T13:13:03Z" level=info file=functional_tests.go function:=main.testCopyObjectV2 line#=3060
time="2017-08-07T13:13:03Z" level=info file=functional_tests.go function:=main.testFunctionalV2 line#=3770
time="2017-08-07T13:13:03Z" level=info file=functional_tests.go function:=main.testComposeObjectErrorCasesV2 line#=3279
time="2017-08-07T13:13:03Z" level=info file=functional_tests.go function:=main.testCompose10KSourcesV2 line#=3344
time="2017-08-07T13:13:03Z" level=info file=functional_tests.go function:=main.testEncryptedCopyObjectV2 line#=3437
time="2017-08-07T13:13:03Z" level=info file=functional_tests.go function:=main.testUserMetadataCopyingV2 line#=3595
time="2017-08-07T13:13:04Z" level=info file=functional_tests.go function:=main.testPutObject0ByteV2 line#=3676
time="2017-08-07T13:13:04Z" level=info file=functional_tests.go function:=main.testPutObjectNoLengthV2 line#=3614
time="2017-08-07T13:13:04Z" level=info file=functional_tests.go function:=main.testMakeBucketError line#=122
time="2017-08-07T13:13:04Z" level=info msg="skipping region functional tests for non s3 runs" file=functional_tests.go function:=main.testMakeBucketError line#=125
time="2017-08-07T13:13:04Z" level=info file=functional_tests.go function:=main.testMakeBucketRegions line#=171
time="2017-08-07T13:13:04Z" level=info msg="skipping region functional tests for non s3 runs" file=functional_tests.go function:=main.testMakeBucketRegions line#=174
time="2017-08-07T13:13:04Z" level=info file=functional_tests.go function:=main.testPutObjectWithMetadata line#=310
time="2017-08-07T13:13:04Z" level=info file=functional_tests.go function:=main.testPutObjectReadAt line#=225
time="2017-08-07T13:13:05Z" level=info file=functional_tests.go function:=main.testPutObjectStreaming line#=403
time="2017-08-07T13:13:05Z" level=info file=functional_tests.go function:=main.testListPartiallyUploaded line#=465
time="2017-08-07T13:13:05Z" level=info file=functional_tests.go function:=main.testGetObjectSeekEnd line#=539
time="2017-08-07T13:13:05Z" level=info file=functional_tests.go function:=main.testGetObjectClosedTwice line#=631
time="2017-08-07T13:13:05Z" level=info file=functional_tests.go function:=main.testRemoveMultipleObjects line#=708
time="2017-08-07T13:13:14Z" level=info file=functional_tests.go function:=main.testRemovePartiallyUploaded line#=780
time="2017-08-07T13:13:14Z" level=info file=functional_tests.go function:=main.testFPutObjectMultipart line#=847
time="2017-08-07T13:13:14Z" level=fatal msg="Error: number of bytes does not match, want 67108864, got 68157440\n" file=functional_tests.go function:=main.testFPutObjectMultipart line#=910

@poornas
Copy link
Contributor Author

poornas commented Aug 14, 2017

updated PR to use release tags - @nitisht , the output log is being written to error.log above because logrus by default writes to stderr. Sent a PR to fix default output for logger in minio-go.

Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests running fine, logs are still getting populated in error.log but that will be fixed after next minio-go release.

@poornas can you please file an issue to update to new minio-go as we make a release after merging minio/minio-go#786

@deekoder deekoder merged commit 6e7657b into minio:master Aug 15, 2017
@poornas poornas deleted the gitgo branch August 15, 2017 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants