fix: update tenant status when pool removal is disallowed (#2486)

drivebyer · web-flow · commit 1e792f1158c9 · 2025-09-05T14:44:44.000+08:00
Signed-off-by: drivebyer &lt;wuyangmuc@gmail.com&gt;
diff --git a/pkg/controller/decomission.go b/pkg/controller/decomission.go
@@ -79,6 +79,9 @@ func (c *Controller) checkForPoolDecommission(ctx context.Context, key string, t
 		}
 		if noDecomCommon {
 			klog.Warningf("%s Detected we are removing a pool but spec.Pool[].Name's are duplicated - disallowing removal", key)
+			if _, err = c.updateTenantStatus(ctx, tenant, StatusDecommissioningNotAllowed, 0); err != nil {
+				return nil, err
+			}
 			return nil, errors.New("removing pool not allowed")
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,9 @@ func (c *Controller) checkForPoolDecommission(ctx context.Context, key string, t`
`79`	`79`	`}`
`80`	`80`	`if noDecomCommon {`
`81`	`81`	`klog.Warningf("%s Detected we are removing a pool but spec.Pool[].Name's are duplicated - disallowing removal", key)`
	`82`	`+ if _, err = c.updateTenantStatus(ctx, tenant, StatusDecommissioningNotAllowed, 0); err != nil {`
	`83`	`+ return nil, err`
	`84`	`+ }`
`82`	`85`	`return nil, errors.New("removing pool not allowed")`
`83`	`86`	`}`
`84`	`87`