Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not validate NS in expand tenant command #1291

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Do not validate NS in expand tenant command #1291

merged 3 commits into from
Sep 22, 2022

Conversation

reivaj05
Copy link
Contributor

@reivaj05 reivaj05 commented Sep 16, 2022 •
edited
Loading

Now namespace will only validated in create tenant command and it won't for the expand command

Fixes: #1289

harshavardhana
harshavardhana previously approved these changes Sep 16, 2022
View reviewed changes
dilverse
dilverse previously approved these changes Sep 16, 2022
View reviewed changes
@reivaj05 reivaj05 self-assigned this Sep 16, 2022
harshavardhana
harshavardhana previously approved these changes Sep 16, 2022
View reviewed changes
dvaldivia
dvaldivia previously requested changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but how will we be able to tell one tenant from another if they have the same name? is there another mechanism to specify the namespace?

@reivaj05 reivaj05 dismissed dvaldivia’s stale review September 19, 2022 16:15

namespace flag was added to expand command, in case namespace is not provided code will try to get it automatically by using tenant name

@harshavardhana harshavardhana merged commit 9dbfcbe into minio:master Sep 22, 2022
@johnjairus10 johnjairus10 mentioned this pull request Dec 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@dilverse dilverse dilverse approved these changes

@Alevsk Alevsk Awaiting requested review from Alevsk

@bexsoft bexsoft Awaiting requested review from bexsoft

@cniackz cniackz Awaiting requested review from cniackz

@pjuarezd pjuarezd Awaiting requested review from pjuarezd

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

Assignees

@reivaj05 reivaj05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand command is broken
4 participants
@reivaj05 @harshavardhana @dvaldivia @dilverse