-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests also with Selenium 3.x #354
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
============================================
- Coverage 90.02% 87.73% -2.29%
+ Complexity 150 149 -1
============================================
Files 1 1
Lines 421 367 -54
============================================
- Hits 379 322 -57
- Misses 42 45 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6580799
to
d358fb1
Compare
d358fb1
to
87e6203
Compare
caf6a13
to
99f3677
Compare
test must be fixed, only integer indexes are accepted, when string
the uploaded paths are newly validated if exist and canonical, of course from browser, thus we must use some paths available within the browser container
Selenium 3.x + Chrome is working, Firefox is broken - and only impossible to fix https://stackoverflow.com/questions/25760357/get-title-of-window-without-switching-in-selenium-webdriver, developer must pass window handle instead of window name (which can also be duplicate) (only) handle support fixed in instaclick/php-webdriver#119 null handle fixed by retriving all handles and using the 1st one (the results is ordered, so the 1st one should always be main windows handle)
/w Selenium 2x the following exception is thrown:
/w Selenium 3.x no exception is thrown with Firefox, in Chrome, exception is thrown, but a different one -
natively via webdriver it seems impossible/broken,
is not emitting right click either the only fix seems to migrate to new webdriver actions - https://stackoverflow.com/questions/2171589/how-can-you-do-right-click-using-selenium/19123275#19123275 |
99f3677
to
3d1c8d1
Compare
Does Selenium 3 still follow the JsonWire protocol, that allows Otherwise, an upgrade Selenium is only removing stuff instead of adding it :( . Offtopic: There are also unmerged/closed PRs with attempts to use https://github.com/php-webdriver/php-webdriver in this driver instead. Maybe we should move in that direction, @stof ? |
There were 3 errored and 2 failing tests, see post below for analysis and how they were fixed.