-
Notifications
You must be signed in to change notification settings - Fork 16
Add Twoslash support to @mintlify/mdx (behind trigger) #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
c6bcfec
to
32b0a3e
Compare
32b0a3e
to
926e458
Compare
926e458
to
e9ff8fa
Compare
e9ff8fa
to
d478484
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't get it to work with mint and local package according to the test plan, but the new examples in app-router and pages-router here give me confidence this is set up correctly and that that was user error. :lgtm: Lets Get This Merged!!
Add Twoslash support via transformer to Shiki codeblock parsing step hidden behind explicit trigger.
Closes ENG-4255
Test Plan
Disable explicit triggers by setting
explicitTrigger: false
inrehypeSyntaxHighlighting.ts
.In
mint
, replace all instances of"@mintlify/mdx"
versions inpackage.json
files withfile:/path/to/mdx/packages/mdx
and runyarn
Add the following CSS to `client` (this will be modified, but it's just to verify everything works)
Open http://acme.localhost:3000/api/hello and look at the code blocks.