Deep/eng 3060 code blocks line highlighting #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
deep93333
changed the title
dks333
requested changes
Oct 19, 2024
|
Quick question (might not be included in the initial design): Do we need to highlight codes without languages being specified? |
dks333
requested changes
Oct 21, 2024
dks333
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Example
Test plan
To locally test this package in mint we need to link this project. To link this project i was using https://github.com/wclr/yalc i was struggling to link with yarn or npm. I found out mint project uses yarn 3 while mdx repo is using yarn 1 so there was compatibility issue.