Seating Plan Updates #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating larger seating plans, the default scale of the grid means that the plan ends up quite big. Added a percentile-based scale which can scale the layout grid down (or up) to help with larger layouts.
In some cases, if there isnt a seat placed at the bottom of the background image, it'll get cut off either to the bottom or the right.
Last fix wasnt actually the right thing. Now looking at the actual size of the background image and setting the element to that size.
Missed a page
mintopia
requested changes
Sep 5, 2024
Change the image height and width to be calculated on seating plan property save instead of loaded on each page load.
mintopia
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating larger seating plans, the default scale of the grid means that the plan ends up quite big.