Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add webp fallback #212

Merged
merged 10 commits into from
Oct 12, 2017
Merged

add webp fallback #212

merged 10 commits into from
Oct 12, 2017

Conversation

wupengFEX
Copy link
Member

add webp fallback

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.779% when pulling d3a12e5 on wupengFEX:develop into 8ce5a5f on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.779% when pulling 06ab50a on wupengFEX:develop into 8ce5a5f on mipengine:master.

dongshihao
dongshihao reviewed Sep 26, 2017
View reviewed changes
src/components/mip-img.js Outdated
if (/[\?&]mip_img_ori[&]*/.test(ele.search)) {
return;
}
var search = ele.search ? ele.search : '?';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var search = ele.search || '?'; 这个可以么

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.779% when pulling b3ca39e on wupengFEX:develop into 8ce5a5f on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.779% when pulling 1bf4816 on wupengFEX:develop into 8ce5a5f on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.779% when pulling 681d806 on wupengFEX:develop into 8ce5a5f on mipengine:master.

@dongshihao dongshihao merged commit 108cbdc into mipengine:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongshihao dongshihao dongshihao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wupengFEX @coveralls @dongshihao