-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to a single package (step 1) #60
Conversation
@samoht rebased according to your review ! |
Just to fully understand: the only thing that this PR is doing is moving the compilation of C stubs into the main package, so that's |
Yes, instead of having |
But then, I am not sure to understand why we need to keep I think it's just better to remove these and add bounds to the rev-dependencies. I'm fine doing this myself. |
It's just because revdeps still depend on |
I can help fixing the revdeps. I think it's better to just remove these packages if they are not useful (and if they won't be able to link with existing unikernels using ocamlbuild anyway as they will not be cross-compiled correctly). |
See ocaml/opam-repository#14621 for the revdeps fixes |
the cross-compilation will be done directly by dune
Now that ocaml/opam-repository#14621 is merged, I've pushed to the PR to remove |
This is fine, but let's please document clearly in the CHANGES file that the reason it works is that existing ocamlbuild setups will pickup io-page-xen/unix, whereas mirage4 won't need them at all. Otherwise it's not clear what happens to old packages. |
I'd suggest to add a |
CHANGES: * Use workspace flags (@TheLortex, mirage/io-page#60) * Use ocamlformat (@TheLortex, mirage/io-page#60) * **breaking changes** Remove io-page-xen and io-page-unix split (@samoht, mirage/io-page#60) * Update CI scripts (@samoht, mirage/io-page#60) * **breaking changes** Update the C layout of io-page according MirageOS 3/4 (@dinosaure, mirage/io-page#62) JS/C functions are renamed from `mirage_*` to `caml_mirage_iopage_*` * Add ocaml-freestanding and pkg-config as dependencies of `io-page` To be able to 'cross'-compile to Solo5
CHANGES: * Use workspace flags (@TheLortex, mirage/io-page#60) * Use ocamlformat (@TheLortex, mirage/io-page#60) * **breaking changes** Remove io-page-xen and io-page-unix split (@samoht, mirage/io-page#60) * Update CI scripts (@samoht, mirage/io-page#60) * **breaking changes** Update the C layout of io-page according MirageOS 3/4 (@dinosaure, mirage/io-page#62) JS/C functions are renamed from `mirage_*` to `caml_mirage_iopage_*` * Add ocaml-freestanding and pkg-config as dependencies of `io-page` To be able to 'cross'-compile to Solo5
In the mirage+dune series of PR (mirage/mirage#969).
Workspace flags
Use
:standard
to get the flags from the build workspace. This means xen/unix flags are automatically set up and we don't need to know about backends anymore.Compatibility stubs
We keep
io-page-xen
andio-page-unix
in order not to have to modify every revdep.