Skip to content

Conversation

remi
Copy link
Member

@remi remi commented Apr 2, 2019

Dispatch.extract_from_params/1 assumed that there always was a stacks query parameter present in the webhook URL. It means pull requests in repositories without default stacks were always stackless.

Now it doesn’t anymore 😄

@remi remi requested a review from garno April 2, 2019 14:43
@mirego-builds mirego-builds requested a review from simonprev April 2, 2019 14:43
@mirego-builds
Copy link

🦀 Requesting reviewers for this pull request:

  • @garno (contributor with 5 commits in the last 90 days and 5 commits overall)
  • @simonprev (reviewer for the elixir stack)

@remi remi merged commit 23a86a9 into master Apr 2, 2019
@remi remi deleted the fix/make-pr-body-stacks-work-even-without-default-stacks branch April 2, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants