Don't create custom literal parser by default #387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've did deep dive into GraphQL's query executor and found that if scalar has no literal parser, GraphQL executor will use default one, which did exactly what our default one, eg. convert AST value to python type, then call
parse_value
for field.In this PR I've added tests cementing this behavior in the core, and removed our fallback default literal parser. I'll also open issue on our docs to remember to update that
parse_literal
is not required if your scalar doesn't need custom AST unpacking logic.Fixes #371