Directive definition regex pref #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2022 13:29
\s matches [ \t\n\r\f\v]
Codecov Report
@@ Coverage Diff @@
## master #847 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 93 93
Lines 5451 5451
=======================================
Hits 5349 5349
Misses 102 102
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
added 2 commits
April 19, 2022 16:09
rafalp
approved these changes
Apr 20, 2022
|
Thank you! |
|
Gosh, I've missed CI not running by GH again and this change has broken the build. I'm at lost of words on GH for this :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#775 Introduced a performance issue: #775 (comment)
The solution is to add start and end anchors to the comment regexes.